Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc: collect entries where the refcounter could underflow and wrap #1517

Open
tixxdz opened this issue Sep 28, 2023 · 2 comments
Open

gc: collect entries where the refcounter could underflow and wrap #1517

tixxdz opened this issue Sep 28, 2023 · 2 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@tixxdz
Copy link
Member

tixxdz commented Sep 28, 2023

What happened?

Inside gc we discard process entries with a refcounter that could underflow and wrap, such entries won't be on the deletequeue again and will stay forever.

I have identified what could be the real cause but need to assert that our current tests and logic could handle this or write more tests for it, and also document the refcounting logic.

Tetragon Version

all

Kernel Version

doesn't matter

Kubernetes Version

No response

Bugtool

No response

Relevant log output

No response

Anything else?

No response

@tixxdz tixxdz added the kind/bug Something isn't working label Sep 28, 2023
@tixxdz tixxdz self-assigned this Sep 28, 2023
@Jay-JHe
Copy link

Jay-JHe commented Oct 11, 2023

@tixxdz Hi, may I ask if there has been any progress regarding this issue?

@jrfastab jrfastab self-assigned this Oct 20, 2023
@tixxdz
Copy link
Member Author

tixxdz commented Oct 23, 2023

@tixxdz Hi, may I ask if there has been any progress regarding this issue?

Hi @Jay-JHe for this to happen another bug must trigger it, as we have fixed that one #1485, I think we are good for now. Nevertheless we have to make gc robust regardless of that, so I'm planning this fix shortly after we tag 1.0 , as changing the gc logic now can introduce new bugs ;-) . let's see what @jrfastab thinks too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants