Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain whitelisting via menu #41

Closed
birdie-github opened this issue Sep 27, 2018 · 2 comments
Closed

Domain whitelisting via menu #41

birdie-github opened this issue Sep 27, 2018 · 2 comments

Comments

@birdie-github
Copy link

It would be great if the add-on allowed to white list domains (for simplicity sake the domain of the address bar) via its menu or alternatively, each domain which matches the rewrite rules.

@Cimbali
Copy link
Owner

Cimbali commented Sep 27, 2018

This is already possible.

Clicking on the CleanLinks icon opens a popup with the list of cleaned links. You can then select any cleaned link and click the "Whitelist Selection" button, which will add the origin's domain to the whitelist.

@Cimbali Cimbali closed this as completed Sep 27, 2018
@OdinVex
Copy link

OdinVex commented Mar 17, 2024

This is already possible.

Clicking on the CleanLinks icon opens a popup with the list of cleaned links. You can then select any cleaned link and click the "Whitelist Selection" button, which will add the origin's domain to the whitelist.

That doesn't at all seem to be allowing for a domain, it seems to only allow a single URL. Edit: It's also completely useless for certain kinds of authentication. Home Assistant? Forget it, just disable CleanLinks. Matching all subdomains and ^.*$ path with "Allow (allowlist) URL embedded inside pathenabled andAllow javashit to modify links` enabled with nothing else won't even address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants