macOS screensaver crashes on exit

[Lord-Kamina]

I noticed this while using the Cinder version of the old Spectrum macOS screensaver. I had been getting this error for a while so I decided to look into it a bit.

I tried rebuilding cinder (using the 0.9.2 release, although I don't see anything in master that looks like it'd contribute to fix the issue; only a few errors like missing headers which I'd also fixed on my local working copy as I found them), disregard this, I was just very tired and was using master. and then the screensaver but the error persists.

Here's the stack trace:

Process:               ScreenSaverEngine [24716]
Path:                  /System/Library/CoreServices/ScreenSaverEngine.app/Contents/MacOS/ScreenSaverEngine
Identifier:            com.apple.ScreenSaver.Engine
Version:               5.0 (5.0)
Build Info:            ScreenSaver-297001000000000~56
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           ScreenSaverEngine [24716]
User ID:               501

PlugIn Path:             /Users/USER/Library/Screen Savers/SpectrumSaver.saver/Contents/MacOS/SpectrumSaver
PlugIn Identifier:       org.libcinder.SpectrumSaver
PlugIn Version:          1.0 (1)

Date/Time:             2020-07-18 10:51:16.316 -0400
OS Version:            Mac OS X 10.14.6 (18G5033)
Report Version:        12
Bridge OS Version:     3.0 (14Y908)
Anonymous UUID:        EA9784FA-1965-044C-73CA-79464B4271C5

Sleep/Wake UUID:       6B1BD1E9-10EC-435B-8151-4CEA187D7FA8

Time Awake Since Boot: 100000 seconds
Time Since Wake:       88000 seconds

System Integrity Protection: disabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000310
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [24716]

VM Regions Near 0x310:
--> 
    __TEXT                 0000000108f9d000-0000000108f9f000 [    8K] r-x/rwx SM=COW  /System/Library/CoreServices/ScreenSaverEngine.app/Contents/MacOS/ScreenSaverEngine

Application Specific Information:
dyld3 mode

Application Specific Signatures:
SpectrumSaver

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   org.libcinder.SpectrumSaver   	0x000000010b5d913e cinder::signals::detail::SignalProto<void (), cinder::signals::detail::CollectorDefault<void> >::emit(cinder::signals::detail::CollectorDefault<void>&) + 14
1   org.libcinder.SpectrumSaver   	0x000000010b5d7f18 cinder::app::Window::emitClose() + 24
2   org.libcinder.SpectrumSaver   	0x000000010b4fb131 -[AppImplMacScreenSaverSpectrumSaver removeCinderView:] + 49
3   org.libcinder.SpectrumSaver   	0x000000010b4f9e55 -[WindowImplCocoaScreenSaverSpectrumSaver stopAnimation] + 261
4   com.apple.ScreenSaver         	0x00007fff46b105f8 -[ScreenSaverEngine readjustDisplays] + 317
5   com.apple.ScreenSaver.Engine  	0x0000000108f9e9ad -[ScreenSaverApplication sendEvent:] + 651
6   com.apple.AppKit              	0x00007fff38c2c5c0 -[NSApplication run] + 755
7   com.apple.ScreenSaver.Engine  	0x0000000108f9e2c9 main + 656
8   libdyld.dylib                 	0x00007fff675cb3d5 start + 1

...

Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x00000000000000d0  rbx: 0x0000600003204200  rcx: 0x0000600002a08090  rdx: 0x0000000000000000
  rdi: 0x0000000000000308  rsi: 0x00007ffee6c62878  rbp: 0x00007ffee6c62860  rsp: 0x00007ffee6c62840
   r8: 0x000000000007af8c   r9: 0xffffffff00000000  r10: 0x000000010b702f70  r11: 0x00007fde44200010
  r12: 0x00007fff65dee680  r13: 0x00007fff397c32d1  r14: 0x0000000000000308  r15: 0x00007fff65dee680
  rip: 0x000000010b5d913e  rfl: 0x0000000000010202  cr2: 0x0000000000000310
  
Logical CPU:     2
Error Code:      0x00000004
Trap Number:     14