Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite tests as they fail in CI #44

Open
Cinderella-Man opened this issue Oct 4, 2019 · 0 comments
Open

Rewrite tests as they fail in CI #44

Cinderella-Man opened this issue Oct 4, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@Cinderella-Man
Copy link
Owner

Currently all tests for naive trader are setting up whole environment(BinanceMock, DummyStreamer etc) and try to publish events that will cause some specific behaviour of Naive trading strategy (buy, sell, stop loss, rebuy, retarget etc.).

All those tests are working locally but as pointed above they require processes with state existing which means that they can't be run parallel.

Other sad fact is that they run completely fine locally but intermittently fail in CI.

Opportunity here would be to refactor tests (and possibly code) so they confirm expected behaviours but they don't rely on global state (processes etc)

@Cinderella-Man Cinderella-Man added the enhancement New feature or request label Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant