Enable explicit API mode, add explicit visibility and typing to comply #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsmb13
force-pushed
the
feature/explicit-api-mode
branch
from
edc3ebc
to
210f874
Compare
zsmb13
force-pushed
the
feature/explicit-api-mode
branch
from
210f874
to
e32a3e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables explicit API mode, which requires explicit visibility modifiers for all declarations, and explicit types for public declarations. I made educated guesses about what you'd want public and not public in the library, most importantly, made all
KiteResParserimplementationsinternal, only exposing them through the interface.Also enables progressive mode as a bonus, as that's also a compiler property that can be specified the same way.