Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed waf xml not updating during ckan harvest #78

Closed
fostermh opened this issue Jan 28, 2021 · 2 comments
Closed

changed waf xml not updating during ckan harvest #78

fostermh opened this issue Jan 28, 2021 · 2 comments
Assignees

Comments

@fostermh
Copy link
Member

re-harvesting of WAF metadata does not update a dataset even though it has been changed on the waf. Perhaps an issue with how waf_modified_date is populated?

reportedby Étienne.

@fostermh
Copy link
Member Author

this Line 752 in the spatial harvester base checkes metadata_date of old and new harvested metadatra when doing an update. metadata_date is populated from "metadata-date" in spatial model harvester Line 713.

Currently metadata-date is populated by the following xpaths:

"mdb:dateInfo/cit:CI_Date[cit:dateType/cit:CI_DateTypeCode/@codeListValue='creation']/cit:date/gco:Date/text()",
"mdb:dateInfo/cit:CI_Date[cit:dateType/cit:CI_DateTypeCode/text()='creation']/cit:date/gco:Date/text()",
"mdb:dateInfo/cit:CI_Date[cit:dateType/cit:CI_DateTypeCode/@codeListValue='creation']/cit:date/gco:DateTime/text()",
"mdb:dateInfo/cit:CI_Date[cit:dateType/cit:CI_DateTypeCode/text()='creation']/cit:date/gco:DateTime/text()",

This does not take into account publication or revision dates. It probably should.

The current setup of the harvester requires a change to the dates in the metadata before a record will be updated. This is likely good metadata practice but may not be convenient for some workflows. More discussion needed.

@fostermh
Copy link
Member Author

fostermh commented Apr 8, 2021

update the metadata-entry-form now updates the lastUpdated data every time the form is saved so this is no longer an issue with metadata generated from the form. Correct metadata would be to update this date when changing the xml anyway so I think this is the appropriate workflow.

@fostermh fostermh closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant