Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use export-hook in core #30

Closed
travisbrown opened this issue Aug 12, 2015 · 3 comments
Closed

Use export-hook in core #30

travisbrown opened this issue Aug 12, 2015 · 3 comments

Comments

@travisbrown
Copy link
Member

I'm creating this issue to follow up on a comment by @dwijnand on gitter:

The only thought I had about #29 is the need for the imports, and I that made me think if maybe core should use export-hook

I've played around with export-hook in core, but I really want to push on the experiment of keeping generic derivation modular for as long as possible. I don't love my current approach of getting priorities right by balancing a tower of instance-providing traits and using a Secondary wrapper, but it seems to work reasonably well, and is still (I think) not completely unintelligible.

@travisbrown
Copy link
Member Author

I'm removing the question tag since @milessabin has just convinced me that export-hook can do what I want. I'll tackle this next week unless someone beats me to it.

@travisbrown
Copy link
Member Author

Fixed by #43.

@dwijnand
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants