Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the orb doesn't seem to install the latest version of a CLI or it doesn't re-install when version is changed in config.yml #30

Closed
smostovoy opened this issue Jan 2, 2020 · 3 comments · Fixed by #31

Comments

@smostovoy
Copy link

smostovoy commented Jan 2, 2020

The command and error are:
aws ecs register-task-definition --cli-input-json file://./tmp/task-definition.json --network-mode awsvpc --requires-compatibilities FARGATE --region ********* --family se-dev-2699

Parameter validation failed:
Unknown parameter in containerDefinitions[6]: "firelensConfiguration", must be one of: name, image, repositoryCredentials, cpu, memory, memoryReservation, links, portMappings, essential, entryPoint, command, environment, mountPoints, volumesFrom, linuxParameters, secrets, dependsOn, startTimeout, stopTimeout, hostname, user, workingDirectory, disableNetworking, privileged, readonlyRootFilesystem, dnsServers, dnsSearchDomains, extraHosts, dockerSecurityOptions, interactive, pseudoTerminal, dockerLabels, ulimits, logConfiguration, healthCheck, systemControls, resourceRequirements

My setup looks like this:

version: 2.1
orbs:
  docker: circleci/docker@0.5.13
  aws-cli: circleci/aws-cli@0.1.19
jobs:
  deploy:
    executor: docker/machine
    steps:
      - aws-cli/setup:
          aws-access-key-id: QA_AWS_ACCESS_KEY_ID
          aws-secret-access-key: QA_AWS_SECRET_ACCESS_KEY
          aws-region: QA_AWS_REGION
     - run: scripts/build

scripts/build is creating a TaskDefinition in ECS with a Firelens a log adapter. This new AWS option didn't work untill I added - run: pip install --upgrade awscli before it. Before that I had a version 0.1.18 of the orb and it was changed to 0.1.19 and nothing changed.

@jaakkoleht
Copy link

Same thing with describe-image-scan-findings-aws cli command. Took me ages to find out what is wrong until I realized the aws cli version might be wrong. The orbs install should have a variable for aws cli version, like latest or xx.xx. Does someone actively develop these orbs or should I make pull request about it?

@lokst
Copy link
Contributor

lokst commented Feb 5, 2020

@smostovoy @jaakkoleht Thanks for the report and apologies for the delay in response! It looks like you might be encountering this issue due to the executor used. For instance, the ubuntu-1604:201903-01 machine image comes with an older version of the CLI preinstalled, which causes this orb to skip installing the CLI as it detects the existing version. We're working on a solution for this and will post again once it's released.

@lokst
Copy link
Contributor

lokst commented Feb 6, 2020

I would recommend using the newly released version 0.1.20 of the orb, which introduces a skip-install-check parameter in the install and setup commands, which will help with this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants