Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to install yarn on a container with a user #74

Closed
cyrilchampier opened this issue Feb 22, 2021 · 4 comments
Closed

Impossible to install yarn on a container with a user #74

cyrilchampier opened this issue Feb 22, 2021 · 4 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@cyrilchampier
Copy link

Orb version:

4.1.1

What happened:

This configuration fails:

      - node/install:
          install-yarn: true
          install-npm: false
          node-version: 14.15.2

Because we defined a "USER" in our image, and that sudo is not available.

Expected behavior:

yarn install with the current user, without trying to sudo.

Additional Information:

Due to this line:
https://github.com/CircleCI-Public/node-orb/blob/master/src/scripts/install-yarn.sh#L1

@cyrilchampier cyrilchampier added the bug Something isn't working label Feb 22, 2021
@gmemstr
Copy link
Contributor

gmemstr commented Feb 24, 2021

If you're using a custom Docker image, I would recommend pre-installing Yarn rather than installing it during runtime. This will remove the complexity and time overhead associated with installing on-the-fly. There are some instances where we have tried to compensate or detect a lack of sudo in orbs, but generally we try to encourage users to consider pre-installing in their images.

@Jaryt
Copy link
Contributor

Jaryt commented Dec 13, 2021

Hi @cyrilchampier hope you're doing well! It's been some time since Gabe's response, do we have any updates here?

@Jaryt Jaryt added the wontfix This will not be worked on label Dec 14, 2021
@Jaryt
Copy link
Contributor

Jaryt commented Dec 14, 2021

Marking as wontfix and closing since preinstalling yarn is the better solution for custom images.

@Jaryt Jaryt closed this as completed Dec 14, 2021
@cyrilchampier
Copy link
Author

Hi @Jaryt , thanks for closing the issue, I missed the reply.
Indeed, preinstalling thing in our docker image is the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants