Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license notice re: reproduced code #27

Closed
4 tasks
prestwich opened this issue Oct 2, 2023 · 2 comments
Closed
4 tasks

Add license notice re: reproduced code #27

prestwich opened this issue Oct 2, 2023 · 2 comments

Comments

@prestwich
Copy link

prestwich commented Oct 2, 2023

This repo contains code derived from Nomad contracts without proper attribution and license information. As an author of the code involved, I'm happy that you found the work useful. Reuse of our code is praise

However, to use our work in compliance with the license, please add the appropriate MIT or Apache-2.0 license text (at your option) information to the files containing reproduced or derived code as well as a note in the README that some work is reproduced under the appropriate license

I have not done a full compliance audit of the code base, and do not have a full list of files in need of license notices. However, here is a simple example:

  • This code region is a slightly modified version of this code region, but the file contains no indication that the work is used under either available FLOSS license.
Screenshot 2023-10-01 at 17 09 48

TODOs

  • Add license notice to files containing derivative or reproduced code
  • Add note to README describing source and authorship of reproduced code
  • Notify etherscan verification team of incomplete license information in hosted source files
  • Optional: cite our work in public comms and/or documentation
@walkerq
Copy link
Contributor

walkerq commented Oct 2, 2023

Hey @prestwich,

Thanks for raising this issue. We do import your library, memview-sol - we appreciate your work on that, and many other contributions to the space! Regarding other files in https://github.com/circlefin/evm-cctp-contracts, we have updated the license notice, and README, with attribution: #28.

We are also reaching out to Etherscan to hopefully get that license added.

@prestwich
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants