Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only compare replays most likely to be replay steals #83

Closed
tybug opened this issue Aug 17, 2019 · 1 comment
Closed

Only compare replays most likely to be replay steals #83

tybug opened this issue Aug 17, 2019 · 1 comment

Comments

@tybug
Copy link
Contributor

tybug commented Aug 17, 2019

Determining replays that shouldn't be downloaded is a bit out of scope for this issue (too many different cases, very large potential to have unintended results) but we can provide an option to pass a predicate function to determine if two replays should be compared. Similar to include, but for comparisons. Both Replay objects will be provided so users can choose to compare or not compare based on acc/mods/user id/any other metric. This can later be extended to some form of generic setting that will cover use cases for both include and this new option.

Also possibly provide several presets (STRICT, NORMAL, LOOSE, ALL), with decreasing amounts of comparisons rejected until ALL which does not filter any. Only compare same mod replays within x% and od-affecting mods within a larger percentage. Similarly for misses or otherwise.

Supersedes #74 and #73.

@tybug
Copy link
Contributor Author

tybug commented Sep 17, 2020

This issue is a relic of older versions of circleguard and is no longer even slightly applicable as of 5.0.0. Consumers should implement their own heuristic if they would like to mimic this proposed behavior.

@tybug tybug closed this as completed Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant