Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build against latest circt #6

Merged
merged 1 commit into from Jan 28, 2022
Merged

fix build against latest circt #6

merged 1 commit into from Jan 28, 2022

Conversation

makslevental
Copy link
Contributor

I had to fiddle to get hls-opt to compile against circt main (i.e., bbe0104fcb1c67190c929c3da8ab2e9f8f0e33fd). in general i'm not sure if you're pinning against some circt version...

@mortbopet
Copy link
Member

thanks for this.

in general I'm not sure if you're pinning against some CIRCT version...

Not at the moment. I think @mikeurbach and i are currently just "winging it" and fixing things on the fly. That is obviously not a good solution long term, nor for when new people want to get into the project. So whether the most sane thing here is to add CIRCT as a submodule, or to point to a fixed commit, I'm not sure - but we should definitely discuss it.

for the CIRCT ODM on Wednesday, I'll be talking a bit about CIRCT-HLS. Hopefully that will lead to a discussion about the future of this repo (whether most/all of it should be included into CIRCT, or if it makes sense to spin it off as a stand-alone thing).

@mortbopet mortbopet merged commit 47c2cef into circt-hls:main Jan 28, 2022
@makslevental makslevental deleted the fix-build-hls-opt branch January 28, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants