Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit f22e626 broke test #35

Closed
y0no opened this issue May 7, 2015 · 8 comments
Closed

Commit f22e626 broke test #35

y0no opened this issue May 7, 2015 · 8 comments
Labels
bug
Milestone
3.2

Comments

@y0no
Copy link
Contributor

y0no commented May 7, 2015

As I say on IRC to @prologic, the last circuit commit (f22e626) seems to broke some tests after being merged with master branch.

@treemo are you on it ?
@prologic
Copy link
Member

prologic commented May 7, 2015

If one of you could look into this and submit a PR that fixes this that would be great :) I'm at work atm so won't be able to look at it till tonight AEST :)

@prologic prologic added the bug label May 7, 2015
@prologic prologic added this to the next milestone May 7, 2015
@prologic
Copy link
Member

prologic commented May 7, 2015

See: #34

@treemo
Copy link
Contributor

treemo commented May 11, 2015

See: #38

@prologic
Copy link
Member

Is this closed by #38?

@y0no
Copy link
Contributor Author

y0no commented May 12, 2015

Tests seems to pass with python 3.4.3 and python 2.7.9. It's good for me.

@y0no y0no closed this as completed May 12, 2015
@prologic
Copy link
Member

Awesome :) We have Travis CI setup now too so hopefully we'll get all tests passing across all supported versions :)

@y0no
Copy link
Contributor Author

y0no commented May 12, 2015

Currently some tests fail under python 2.7 and 3.4 because of SSL library changes.

@prologic
Copy link
Member

kk can we open a new issue regarding that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
3 participants
@treemo @prologic @y0no