Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move image files #138

Open
circumspect opened this issue Feb 28, 2023 · 2 comments
Open

Move image files #138

circumspect opened this issue Feb 28, 2023 · 2 comments
Labels
improvements Improvements to pre-existing features
Milestone

Comments

@circumspect
Copy link
Owner

  • Images make up the bulk of the repository's size (at time of writing, nearly half a gigabyte)
  • The size of the repository scales with the number of supported languages multiplied by the number of cards
  • Not only does Github limit the max size a repository can have, but large repos take longer to clone

Proposed solution: create separate repositories for each language, containing both the images and the localization file for that language

@circumspect circumspect added the improvements Improvements to pre-existing features label Feb 28, 2023
@circumspect
Copy link
Owner Author

Adding a metadata file for cards could also allow people to upload custom expansions as repositories

@circumspect
Copy link
Owner Author

Non-card resources (posters, game guide, character sheet) should probably have per-language repos as well. Bot localization text files should stay here. Translated cards can be treated as expansions

@circumspect circumspect added this to the Silent Falls milestone Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvements Improvements to pre-existing features
Projects
None yet
Development

No branches or pull requests

1 participant