Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Government and GCC High Support #7

Closed
benatsb opened this issue Oct 31, 2022 · 4 comments
Closed

Azure Government and GCC High Support #7

benatsb opened this issue Oct 31, 2022 · 4 comments
Labels
enhancement This issue or pull request will add new or improve existing functionality public-reported This issue is reported by the public users of the tool.

Comments

@benatsb
Copy link

benatsb commented Oct 31, 2022

馃挕 Summary

Added some logic and a new parameter to support targeting Azure Government and GCC High cloud environments. Added examples and details to the readme.

Motivation and context

We almost exclusively with clients in Azure Government and GCC High. Targeting the various services with different connection strings require some tedious checking. Once past the connection strings there are various differences between Commercial Azure/M365 and GCC High.

You can change a parameter and target your cloud environment or further expand to the other Azure Clouds (ie DOD).

Implementation notes

Forked repository could pull into this repo. However, many files were edited to make sure the cloud environment identity is carried through the modules. A review needs to take place.

https://github.com/sentinelblue/ScubaGear

Acceptance criteria

How do we know when this work is done?

  • Validated against a GCC High tenant. I validated against our tenant in GCC High/Azure Gov.
  • How to handle errors that occur to configuration differences in GCC High and Commercial? The Teams provider throws some errors due to missing properties on the 'Get-CsTenant' cmdlt. It appears these values aren't populated in my tenant or not populated in GCC High.
@gdasher gdasher added the enhancement This issue or pull request will add new or improve existing functionality label Nov 1, 2022
@gdasher
Copy link
Collaborator

gdasher commented Nov 1, 2022

Thanks. In an upcoming release, we plan to add the endpoint routing support for GCC High and DoD's various environments, as well as do further testing against GCC High.

@benatsb
Copy link
Author

benatsb commented Nov 1, 2022

Awesome! I work in GCC High land 24/7, so if you have any questions or if there are any ways I can help, I'd love to.

@benatsb benatsb closed this as completed Nov 1, 2022
@gdasher
Copy link
Collaborator

gdasher commented Nov 7, 2022

Re-opening this to track until the support lands

@gdasher gdasher reopened this Nov 7, 2022
@ethanb-cisa
Copy link
Contributor

Closed in #24 . Let us know if you run into issues.

@ethanb-cisa ethanb-cisa added the public-reported This issue is reported by the public users of the tool. label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality public-reported This issue is reported by the public users of the tool.
Projects
None yet
Development

No branches or pull requests

3 participants