Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there is an error on Save for a given page, save any valid data to the database, and give a caution message with context about what was saved #359

Closed
calerubensteingsa opened this issue Jan 10, 2023 · 3 comments
Assignees
Labels
Milestone

Comments

@calerubensteingsa
Copy link
Contributor

calerubensteingsa commented Jan 10, 2023

Context: Right now if you fill out a bunch of data and hit “Save Progress” and there is invalid data, there will be that error, but also it won’t save anything that you entered that was valid. We need to save anything on the page that is valid even when there is an error and give context that partial information has been saved but anything that erred has not been saved.

Acceptance Criteria

When there is an error on the page after hitting "Save Progress"...

  • Only save valid data entered
  • Add a visual indicator with copy describing that valid information has been saved but any fields with errors have not been saved
  • Show in-line errors on the page

See the example here from Figma:
Image

There is an in-line error above for the field that is incorrect (Street address) but other information (Federal Agency and Organization Name) should be saved as they are valid data. Right now nothing would be saved including the valid data. Then there is a caution box explaining that anything with an error was not saved.

@igorkorenfeld
Copy link
Contributor

igorkorenfeld commented Feb 3, 2023

Designs for the indicators:

Success

Invalid data

@calerubensteingsa calerubensteingsa modified the milestones: Sprint 13, Sprint 14 Feb 7, 2023
@loganmeetsworld loganmeetsworld changed the title Update the Save Experience to Only Save Valid Data If there is an error on Save for a given page, save any valid data to the database, and give a caution message with context about what was saved Feb 13, 2023
@kewlguy781 kewlguy781 self-assigned this Feb 17, 2023
@kewlguy781
Copy link
Contributor

The caution dialog have been added. now researching on method of this and see if this is possible.

@kewlguy781
Copy link
Contributor

I have been doing research on this. I have tested the code and watch how they passed the data back and forth. Based on the codes and information I am reading, I am little hesistant about implementing this solution. The problem is the code (most solution if not all on stack_overflow) have instruction to bypass the "clean"/"validate" which I am not very comfortable with it. It could introduce security flaws/holes if we were to save anything that has not been cleaned/validated into the server as it may lead to a way for the server to accidentally execute instructions from "uncleaned"/"not validated" data. cc: @loganmeetsworld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants