Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unauthenticated access by using middleware #543

Closed
Tracked by #528
SSPJ opened this issue Apr 26, 2023 · 1 comment · Fixed by #673
Closed
Tracked by #528

Prevent unauthenticated access by using middleware #543

SSPJ opened this issue Apr 26, 2023 · 1 comment · Fixed by #673
Assignees
Labels
Milestone

Comments

@SSPJ
Copy link
Contributor

SSPJ commented Apr 26, 2023

It is easy to forget @login_required decorators and LoginRequired mixins, so a middlware layer should be installed to ensure only ok-listed routes are accessible when a user is not signed in.

A suitable 3rd party middleware package may not exist, so it may be necessary to write a small middleware. Existing examples in the codebase can be used.

Middleware may also help with bugs like #537 and #405. It could also resolve and close #486.

This work may intersect with #544.

@loganmeetsworld
Copy link
Contributor

As part of this we should also remove the landing page view and only have home be the dashboard (thus requiring authentication for every view in the site)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants