Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues Checking Multiple Defender DLP Policies #22

Closed
skirkpatrickms opened this issue Dec 13, 2022 · 5 comments
Closed

Issues Checking Multiple Defender DLP Policies #22

skirkpatrickms opened this issue Dec 13, 2022 · 5 comments
Labels
bug This issue or pull request addresses broken functionality public-reported This issue is reported by the public users of the tool.

Comments

@skirkpatrickms
Copy link

馃悰 Summary

A tenant with 2 DLP policies was tested. The DLP policies are set for 1 for Teams and 1 for devices. The Teams policy is checking for PII, credit cards, and UK passports. The Device policy only checks for credit cards. The output of the script states that the requirement for PII is met, but not all policies are checking for PII. The script needs to be modified to iterate through the policies and provide the correct output for policies that do not meet the requirement.

@ethanb-cisa ethanb-cisa added the bug This issue or pull request addresses broken functionality label Dec 16, 2022
@ethanb-cisa
Copy link
Contributor

Thanks for reporting this. We will look into it how to fix.

@ethanb-cisa ethanb-cisa added the public-reported This issue is reported by the public users of the tool. label Dec 20, 2022
@nanda-katikaneni nanda-katikaneni added this to the Backlog milestone Jan 3, 2023
@schrolla
Copy link
Collaborator

Need to verify if the assumption that all policies are active and the result is the aggregated logical AND of all those policies or not.

@skirkpatrickms
Copy link
Author

skirkpatrickms commented Jan 10, 2023 via email

@tkol2022
Copy link
Collaborator

Reviewed 12/14

@schrolla @buidav Please review and close if this is OBE. If it is still valid, please check to ensure the size and priority labels are accurate.

@schrolla
Copy link
Collaborator

While the DLP capability allows for processing and evaluating multiple policies in the specified order, the baseline states that "a custom policy" shall be configured. So the requirement being assessed is that a single custom policy contains one or more rules with ALL sensitive info types present. The bug stated above, as I understand it, and please correct me if I'm wrong, is that the test scenario splits the sensitive info types across two different policies. In the case above, I'd evaluate the assessment result as a fail on MS.DEFENDER.4.1v1 as neither has a set of rules that contain the 3 minimum info types (SSN, PII, TIN).
The Defender code was updated for the upcoming release which improved the evaluation logic. I ran a test by creating two custom policies as described above: 1 targeting Teams with SSN, CC, and Passport and a second targeting Devices with only CC. Neither policy included ITIN and these were the only two policies set to On. I ran the test in a G5 tenant. The result was a fail, as expected since no policy contains the required ITIN (which is identified as the missing type in the fail report details for MS.DEFENDER.4.1v1). Also note, that since no single custom policy meets 4.1 the ancillary baselines for MS.DEFENDER.4.2-4.4 also fail since they check additional settings associated with the required info type rules.

Screenshot 2023-12-15 at 8 47 14鈥疉M

As such, I believe the upcoming release addresses this issue by resolving the false positive and that this item can be closed.

@schrolla schrolla removed this from the Backlog milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality public-reported This issue is reported by the public users of the tool.
Projects
None yet
Development

No branches or pull requests

5 participants