You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently there are only checks for docker-compose.yml files in the pre-commit linting. There should also be checks for Dockerfiles. Tools such as Hadolint are good for this, but any similar tools that can be ran as a pre-commit hook would suffice.
Acceptance criteria
Add Dockerfile auditing to the pre-commit linting.
The text was updated successfully, but these errors were encountered:
michaelsaki
added
the
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
label
Mar 18, 2024
I am currently working on a custom Hadolint pre-commit hook that we can integrate seamlessly into the linting. I am trying to leverage the Python library setuptools to package this and enable an auto-install Hadolint, in the pre-commit local environment. Ideally this would make it so users don't have to install Hadolint however I am having issues getting it to work on macOS. https://github.com/michaelsaki/pre-commit-hadolint
Moving this to "on hold" until this PR gets merged. AleksaC/hadolint-py#6. It will provide the simplest solution for the macOS segfault issue when merged into hadolint-py
There is currently a branch for this issue. I have ran the https://github.com/AleksaC/hadolint-py locally and initial tests look good. There will still need to be tests done to have it tested in GitHub Actions. Also prior to integration of the pre-commit hook any downstream repos that have Dockerfiles will need to be ran against hadolint to check for any pre-existing linting errors.
馃挕 Summary
Add
Dockerfile
auditing topre-commit
linting.Motivation and context
Currently there are only checks for
docker-compose.yml
files in thepre-commit
linting. There should also be checks forDockerfiles
. Tools such as Hadolint are good for this, but any similar tools that can be ran as a pre-commit hook would suffice.Acceptance criteria
Dockerfile
auditing to thepre-commit
linting.The text was updated successfully, but these errors were encountered: