Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add maxResultsPerPage prop to APagination #1235

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

mzaharie
Copy link
Contributor

@mzaharie mzaharie commented May 31, 2022

Please check if the PR fulfills these requirements

  • [?] The commit message follows semantic commit message guidelines
  • The changes are documented in component docs and changelog
  • The ESLint plugin has been updated if a new component is added
  • Test have been added or modified, if appropriate
  • Has been verified locally

What kind of change does this PR introduce?

Closes #1183

What is the current behavior?

#1183

What is the new behavior (if this is a feature change)?

Added the new maxResultsPerPage optional prop.

Does this PR introduce a breaking change?

Other information:

@vercel
Copy link

vercel bot commented May 31, 2022

@mzaharie is attempting to deploy a commit to the Cisco SecureX Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
atomic-react ✅ Ready (Inspect) Visit Preview May 31, 2022 at 2:59PM (UTC)

@mzaharie mzaharie force-pushed the feat/pagination-max-results branch from 9a346d4 to 0c7457d Compare June 9, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add maxResults prop to APagination component
1 participant