Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type letter to focus menu item for ASelect #997 #1219

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from
Open

Type letter to focus menu item for ASelect #997 #1219

wants to merge 2 commits into from
+20 −0

Conversation

BogdanV3
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • The commit message follows semantic commit message guidelines
  • The changes are documented in component docs and changelog
  • The ESLint plugin has been updated if a new component is added
  • Test have been added or modified, if appropriate
  • Has been verified locally

What kind of change does this PR introduce?
feature

Closes #997

What is the current behavior?

What is the new behavior (if this is a feature change)?
Focus on the first item that begins with user typed characters.

Does this PR introduce a breaking change?
No

Other information:

@BogdanV3 BogdanV3 requested a review from brennarvo May 23, 2022 13:44
@vercel
Copy link

vercel bot commented May 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
atomic-react ✅ Ready (Inspect) Visit Preview May 23, 2022 at 1:44PM (UTC)

@codecov
Copy link

codecov bot commented May 23, 2022 •
edited
Loading

Codecov Report

Merging #1219 (d2db7c4) into master (a50b971) will decrease coverage by 0.25%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
- Coverage   91.20%   90.95%   -0.26%     
==========================================
  Files         104      104              
  Lines        3162     3174      +12     
  Branches     1054     1056       +2     
==========================================
+ Hits         2884     2887       +3     
- Misses        240      248       +8     
- Partials       38       39       +1
Impacted Files Coverage Δ
framework/components/AMenu/AMenu.js 85.29% <25.00%> (-12.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a50b971...d2db7c4. Read the comment docs.

@BogdanV3
Copy link
Collaborator Author

@brennarvo, if you got some time, please have a look. After the code review, I can move further to fix the tests.
Also: #1216

@BogdanV3
Copy link
Collaborator Author

@brennarvo reminder :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brennarvo brennarvo Awaiting requested review from brennarvo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type letter to focus menu item for ASelect
1 participant
@BogdanV3