sha1_update function name conflict

[ymantijunk]

This is not an issue, just a suggestion to change the function name "sha1_update()" and "sha1()" in "crypto/hash/sha1.c" as it conflicts with a system library.

Thanks for the wonderful soffware.
YM

[hasufell]

linphone upstream seems to have kinda forked libsrtp because of this? That makes it extremely difficult for packagers to support srtp in the linphone provided ortp library. Not really your problem, but if this can fix it...

[cmcqueen]

What's the status with this? linphone's fork of libsrtp is difficult to manage from a package management point-of-view. That is, linphone is relying on a version of libsrtp that has no assignable version number. Can this issue be fixed?

[nuqleo]

There is yet one renaming on git://git.linphone.org/srtp.git repo aes_encrypt to srtp_aes_encrypt to avoid conflict with libzrtpcpp.

[mgorny]

Is sha1_update() even needed as a part of public API? Maybe it would be easier to make it static, or give it hidden visibility.

[jfigus]

I agree that sha1_update() shouldn't be part of the public API. IMHO, none of the crypto/include header files should be published. Unfortunately since sha1_update() is currently in one of the published header files, removing it creates the risk of breaking downstream applications.

[jfigus]

This is resolved by c270245 in the 2_0_0_dev branch.