Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp parameter has inconsistent behaviour #21

Closed
davidmfrey opened this issue Jun 14, 2019 · 0 comments
Closed

timestamp parameter has inconsistent behaviour #21

davidmfrey opened this issue Jun 14, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@davidmfrey
Copy link
Contributor

The timestamp parameter in the params object doesn't behave as I would expect according to the documentation
https://www.mindmeld.com/docs/userguide/dm.html?highlight=timestamp#params
It is listed as a unix timestamp which should be represented in seconds, however the handling of it attempts to differentiate between a seconds and milliseconds measurement.
https://github.com/cisco/mindmeld/blob/master/mindmeld/ser.py#L151
The API definition should include the units and the behaviour should follow the definition.
The current method of checking the number of digits in the timestamp is not robust. This causes confusing behaviour when using timestamps older than 2001.

@davidmfrey davidmfrey changed the title timestamp parameter has strange behaviour timestamp parameter has inconsistent behaviour Jun 14, 2019
@minhtuev minhtuev added the 4.1.1 label Jun 20, 2019
@minhtuev minhtuev added 4.2 and removed 4.1.1 labels Jun 27, 2019
@minhtuev minhtuev assigned vijay120 and unassigned jjjacksn Jul 8, 2019
@minhtuev minhtuev removed the 4.2 label May 1, 2020
@minhtuev minhtuev added the bug Something isn't working label Sep 8, 2020
@vijay120 vijay120 closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants