Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuestionAnswerer load_kb fails on compact JSON file #220

Closed
davidmfrey opened this issue Sep 1, 2020 · 0 comments
Closed

QuestionAnswerer load_kb fails on compact JSON file #220

davidmfrey opened this issue Sep 1, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@davidmfrey
Copy link
Contributor

The following situation demonstrates the problem

Consider a file data.json
[{"id":"1","name":"data1"},{"id":"2","name":"data2"}]

Loading this file with QuestionAnswerer.load_kb() will fail because the JSON is compact. I would suggest adding an option to load a knowledge base by passing in an iterator to allow the user of the library to load the data in whatever method works best for them. The JSON file loader should also handle compact JSON format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants