Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff output may display password #131

Closed
kbreit opened this issue Jul 7, 2020 · 1 comment · Fixed by #157
Closed

diff output may display password #131

kbreit opened this issue Jul 7, 2020 · 1 comment · Fixed by #157
Assignees
@kbreit
Labels
bug Something isn't working

Comments

@kbreit
Copy link
Collaborator

kbreit commented Jul 7, 2020

When showing diff output, Ansible will hide secrets using the no_log parameter. However, the information will still show in the before data structure. This should be hidden as well.
@kbreit kbreit added the bug Something isn't working label Jul 7, 2020
@kbreit kbreit self-assigned this Jul 7, 2020
@kbreit kbreit mentioned this issue Jul 25, 2020
Merged
@kbreit kbreit linked a pull request Jul 25, 2020 that will close this issue
WIP: meraki_webhook - Fix bug which would show values for no log items #157
Merged
@kbreit
Copy link
Collaborator Author

kbreit commented Aug 29, 2020

This has been resolved in 1.4.0 and 2.0.

@kbreit kbreit closed this as completed Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbreit kbreit

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: meraki_webhook - Fix bug which would show values for no log items kbreit/ansible-meraki
1 participant
@kbreit