Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create diff generation method #36

Closed
10 of 19 tasks
kbreit opened this issue Dec 29, 2019 · 1 comment
Closed
10 of 19 tasks

Create diff generation method #36

kbreit opened this issue Dec 29, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request v1.0.0 Issue or PR targets v1.0.0

Comments

@kbreit
Copy link
Collaborator

kbreit commented Dec 29, 2019

Much of the diff creation code in the modules is duplicated. The Meraki class should have a generate_diff method which does the work in a centralized and consistent manner

  • meraki_admin.py
  • meraki_config_template.py
  • meraki_content_filtering.py
  • meraki_device.py
  • meraki_firewalled_services.py
  • meraki_malware.py
  • meraki_mr_l3_firewall.py
  • meraki_mx_l3_firewall.py
  • meraki_mx_l7_firewall.py
  • meraki_nat.py
  • meraki_network.py
  • meraki_organization.py
  • meraki_snmp.py
  • meraki_ssid.py
  • meraki_static_route.py
  • meraki_switchport.py
  • meraki_syslog.py
  • meraki_vlan.py
  • meraki_webhook.py
@kbreit kbreit added the enhancement New feature or request label Dec 29, 2019
@kbreit kbreit self-assigned this Dec 29, 2019
@kbreit kbreit added this to To do in v0.1.0 Status Dec 29, 2019
@kbreit kbreit removed this from To do in v0.1.0 Status Dec 30, 2019
@kbreit kbreit added this to To Do in v1.0.0 Status Dec 30, 2019
@kbreit
Copy link
Collaborator Author

kbreit commented Dec 30, 2019

All modules supporting diff have been converted and will be pushed, with one exception. meraki_nat uses a more complex diff data structure which won't be appropriate for the method.

@kbreit kbreit added this to In progress in v0.1.0 Status Dec 31, 2019
@kbreit kbreit moved this from In progress to Done in v0.1.0 Status Dec 31, 2019
@kbreit kbreit removed this from Done in v0.1.0 Status Dec 31, 2019
@kbreit kbreit added the v1.0.0 Issue or PR targets v1.0.0 label Dec 31, 2019
@kbreit kbreit closed this as completed Jan 1, 2020
@kbreit kbreit removed this from To Do in v1.0.0 Status Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.0.0 Issue or PR targets v1.0.0
Projects
None yet
Development

No branches or pull requests

1 participant