-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: enhance sveltekit redirect #4
Comments
Thank you, that's an excellent idea, will implement that for the next release. :) |
Version 0.8.0 is released now, doing exactly this. It simplified the API quite a bit, so thank you again! Let me know if you have more suggestions. I would like the following signatures: // For compatibility with sveltekit/redirect
redirect(303, '/', { message }, event)
// Redirecting to event.url with 303 status.
redirect({ message }, event)
// Redirecting to '/' with 303 status
redirect('/' , { message }, event) But all the parameter combinations are complicated to combine correctly, so I settled with |
I managed to fix it in version 0.9.1, just released. |
Just saw your updates, nice work! Just added to my project today so will feedback/make some PRs if I notice anything :) |
I played with it today and using it now. I like it, does just what I needed. I ended up using |
Great to hear. :) Just for curiosity, does your |
Was looking around for prior art on doing flash messages in sveltekit and found this project. I was thinking it might be good to stick to the sveltekit style
throw redirect(...)
and maybe (not sure your exact implementation so maybe not possible) you could wrap the sveltekit redirect and add your functionality there so then i can do something like this.The text was updated successfully, but these errors were encountered: