Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version shows error in v0.23.0 #538

Closed
leeyr338 opened this issue May 5, 2019 · 5 comments
Closed

Version shows error in v0.23.0 #538

leeyr338 opened this issue May 5, 2019 · 5 comments
Assignees
@kaikai1024
Labels
bug Something isn't working

Comments

@leeyr338
Copy link
Contributor

leeyr338 commented May 5, 2019

Description

Version shows error in v0.23.0

Steps to Reproduce

  1. [First Step]
    Download CITA release v0.23.0

  2. [Second Step]
    Run

$ bin/cita-env bin/cita-jsonrpc --version

Expected behavior: [What you expect to happen]
Show version as

JsonRpc v0.23.0-161-g12420de-dev

or something shows me that this is a 0.23.0 version.

Actual behavior: [What actually happens]
Show version as

JsonRpc v0.22.0-161-g12420de-dev

Reproduce how often: [What percentage of the time does it reproduce?]
100%

Versions

v0.23.0

Additional Information

NA.
@leeyr338 leeyr338 added the bug Something isn't working label May 5, 2019
@kaikai1024
Copy link
Contributor

kaikai1024 commented May 5, 2019 •
edited

Reason:

It's packaged before v0.23.0 is tagged.

Solution:

Repackage and release v0.23.1

@kaikai1024
Copy link
Contributor

Still show v0.23.0 when tag the v0.23.1.

@kaikai1024 kaikai1024 mentioned this issue May 5, 2019
Merged
@kaikai1024
Copy link
Contributor

https://github.com/cryptape/cita/releases/tag/v0.23.1

@kaikai1024 kaikai1024 mentioned this issue May 5, 2019
Closed
@boundless-forest
Copy link
Contributor

👍

@rainchen
Copy link
Member

rainchen commented May 5, 2019

IMO, should not use git tag to set the version number, should use a const string to set version number in the source code, for example: rust-lang/rust@fc50f32#diff-cc2473a853abfbd75a2f2d0d79eb3592R17

@kaikai1024 kaikai1024 mentioned this issue May 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaikai1024 kaikai1024

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rainchen @kaikai1024 @boundless-forest @leeyr338