Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Close' button in Author card to 'Done' #260

Merged
merged 1 commit into from Oct 11, 2021

Conversation

abelsiqueira
Copy link
Collaborator

Pull request details

List of related issues or pull requests

Refs: #218

Describe the changes made in this pull request

On Author's screen, while adding a new author, change the Close button and its icon to Done and a checkmark.

Before:
image
After:
image

Instructions to review the pull request

cd $(mktemp -d --tmpdir cffinit-pr-218.XXXXXX)
git clone https://github.com/citation-file-format/cffinit .
git checkout 218-use-done-for-author-card
npm install
npm run dev

@fdiblen fdiblen self-requested a review October 11, 2021 08:49
Copy link
Member

@jspaaks jspaaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done good sir, feel free to merge this PR at your convience, then delete the branch. 🥇

Copy link
Collaborator

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution! 🍶

@abelsiqueira abelsiqueira merged commit 35e091c into main Oct 11, 2021
@abelsiqueira abelsiqueira deleted the 218-use-done-for-author-card branch October 11, 2021 12:12
@abelsiqueira
Copy link
Collaborator Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants