Create Societe_archeologique_de_Bordeaux.csl #2298
Conversation
|
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
|
😟 There are some issues with your submission. Please check the test report for details. |
|
@helenR24 -- please don't create new pull requests when you encounter problems. You can address any issues in an existing pull requests (though not the ones were you deleted the branch as you did here) and we're happy to help where you have questions. |
|
Hi, I'm sorry but it's not very clear. I corrected my code so I wanted to delete the other attempts. Thank you. De: "Sebastian Karcher" notifications@github.com @helenR24 -- please don't create new pull requests when you encouter problems. You can address any issues in an existing pull requests (though not the ones were you deleted the branch as you did here) and we're happy to help where you have questions. — |
|
no, sorry -- you'd need to start a new pull request and I'm not seeing that. But once that pull request is up, even if you get an error, please don't close. We'll walk you through how to make changes right there. |
|
Can you just say to me if my file societe-archeologique-de-bordeaux is ok please ? |
|
😟 There are some issues with your submission. Please check the test report for details. |
|
OK, I think the automated test should pass now, but there are a number of remaining issues with the style, it'll take some time to review that properly. |
|
😃 Your submission passed all our automated tests. |
|
Great. Thank you ! Will I receive a notification to confirm it's ok and that it can be found on Zotero depository ? |
| <title>Société Archéologique de Bordeaux</title> | ||
| <title-short>SAB</title-short> | ||
| <id>http://www.zotero.org/styles/societe-archeologique-de-bordeaux</id> | ||
| <link href="http://www.zotero.org/styles/societe-archeologique-de-bordeaux" rel="self"/> |
There was a problem hiding this comment.
did you base this style on an existing one? If so, which?
There was a problem hiding this comment.
(see also https://github.com/citation-style-language/styles/wiki/Style-Requirements#8---template-link for more context)
| <multiple>(dir.)</multiple> | ||
| </term> | ||
| <term name="editortranslator"> | ||
| <single>(éd.)</single> |
There was a problem hiding this comment.
same here. Also pretty sure this isn't the right term. It'd be used when someone both edited and translated a work. You may be thinking of the distinction between editor and editorial-director?
There was a problem hiding this comment.
no it's not a mistake. In history you have "classic" editors, but you also have "editor-translators" who translate ancient sources in old languages (latin, old french,...) in current ones
so just to be sure -- that person would be entered twice in Zotero: both as the translator and as the editor? That's when this term is used.
| </names> | ||
| </macro> | ||
| <macro name="pages"> | ||
| <group> |
There was a problem hiding this comment.
no need for the macro -- just use <text variable="page"/> below in lines 207, 240, etc., then delete the macro here.
There was a problem hiding this comment.
no it doesn't work. I don't have the pages with that
it definitely does work. Did you replace the <text macro="pages"/> with <text variable="page"/>?
There was a problem hiding this comment.
Ok sorry ! I probably misunderstood on yesterday. It works ! :-)
| </group> | ||
| </macro> | ||
| <macro name="title"> | ||
| <choose> |
There was a problem hiding this comment.
this is unnececssarily complicated. Just do
<if type="book" match="any">
<text variable="title" font-style="italic"/>
</if>
<else-if variable="container-title" match="none">
<text variable="title" font-style="italic"/>
</else-if>
<else>
<text variable="title"/>
</else>
There was a problem hiding this comment.
I don't understand where is the problem.
Your code is unnecessarily complex, i.e. uses more conditions than needed.
| </choose> | ||
| </macro> | ||
| <macro name="publisher"> | ||
| <group delimiter=", "> |
There was a problem hiding this comment.
same as for the page macro above -- you don't need this as a macro, just use <text variable="publisher"/> and delete this macro
There was a problem hiding this comment.
this still needs to get fixed
| <key variable="page-first"/> | ||
| </sort> | ||
| <layout suffix="."> | ||
| <group> |
| </group> | ||
| </if> | ||
| <else-if type="webpage"> | ||
| <group> |
| <group delimiter=" "> | ||
| <text macro="title" font-style="italic"/> | ||
| <text variable="URL" prefix="(" suffix=","/> | ||
| <text prefix=" " macro="access" suffix=")"/> |
There was a problem hiding this comment.
remove the prefix=" " -- it's covered by the delimiter above.
| </group> | ||
| </else-if> | ||
| <else-if type="book" match="any"> | ||
| <group> |
| <group> | ||
| <text macro="author" suffix=". "/> | ||
| </group> | ||
| <text macro="title" prefix="« " suffix=" » , "/> |
There was a problem hiding this comment.
use quotes="true" instead of hard-coding the guillements here and elsewhere.
There was a problem hiding this comment.
use quotes="true" instead of hard-coding the guillements here and elsewhere. no because I want to have the french ones, not the english ones
quotes="true" in this style will use French guillemets. Try it out.
|
Hello, please see answers in-line in green. Thank you very much. De: "Sebastian Karcher" notifications@github.com @adam3smith requested changes on this pull request. Please see comments in-line. There are instructions on how to update your pull-request above. Any questions let us know. In societe-archeologique-de-bordeaux.csl :
did you base this style on an existing one? If so, which? this style was never created. I took inspiration on style "Ausonius", "Presses universitaires de Rennes" and "DAF" In societe-archeologique-de-bordeaux.csl :
same here. Also pretty sure this isn't the right term. It'd be used when someone both edited and translated a work. You may be thinking of the distinction between editor and editorial-director? no it's not a mistake. In history you have "classic" editors, but you also have "editor-translators" who translate ancient sources in old languages (latin, old french,...) in current ones In societe-archeologique-de-bordeaux.csl :
no need for the macro -- just use below in lines 207, 240, etc., then delete the macro here. no it doesn't work. I don't have the pages with that In societe-archeologique-de-bordeaux.csl :
this is unnececssarily complicated. Just do In societe-archeologique-de-bordeaux.csl :
same as for the page macro above -- you don't need this as a macro, just use and delete this macro ok In societe-archeologique-de-bordeaux.csl :
no need for this group ok In societe-archeologique-de-bordeaux.csl :
no need for this group. ok In societe-archeologique-de-bordeaux.csl :
no need for this group ok In societe-archeologique-de-bordeaux.csl :
remove the prefix=" " -- it's covered by the delimiter above. I saw another mistake, here the right code : In societe-archeologique-de-bordeaux.csl :
no need for this group ok In societe-archeologique-de-bordeaux.csl :
use quotes="true" instead of hard-coding the guillements here and elsewhere. no because I want to have the french ones, not the english ones — |
|
@heleneR24, do you think you could make some of the requested changes yourself? Instructions on how to update this pull request are at the top (#2298 (comment)). |
|
Yes I can. I will do it as soon as possible. |
|
😃 Your submission passed all our automated tests. |
| <group> | ||
| <text macro="author" suffix=". "/> | ||
| </group> | ||
| <text macro="title" prefix="« " suffix=" » , "/> |
There was a problem hiding this comment.
use quotes="true" instead of hard-coding the guillements here and elsewhere. no because I want to have the french ones, not the english ones
quotes="true" in this style will use French guillemets. Try it out.
| <multiple>(dir.)</multiple> | ||
| </term> | ||
| <term name="editortranslator"> | ||
| <single>(éd.)</single> |
There was a problem hiding this comment.
no it's not a mistake. In history you have "classic" editors, but you also have "editor-translators" who translate ancient sources in old languages (latin, old french,...) in current ones
so just to be sure -- that person would be entered twice in Zotero: both as the translator and as the editor? That's when this term is used.
| </names> | ||
| </macro> | ||
| <macro name="pages"> | ||
| <group> |
There was a problem hiding this comment.
no it doesn't work. I don't have the pages with that
it definitely does work. Did you replace the <text macro="pages"/> with <text variable="page"/>?
| </group> | ||
| </macro> | ||
| <macro name="title"> | ||
| <choose> |
There was a problem hiding this comment.
I don't understand where is the problem.
Your code is unnecessarily complex, i.e. uses more conditions than needed.
| </choose> | ||
| </macro> | ||
| <macro name="publisher"> | ||
| <group delimiter=", "> |
There was a problem hiding this comment.
this still needs to get fixed
|
😟 There are some issues with your submission. Please check the test report for details. |
|
😟 There are some issues with your submission. Please check the test report for details. |
|
😃 Your submission passed all our automated tests. |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="note" demote-non-dropping-particle="never" default-locale="fr-FR" page-range-format="expanded"> | ||
| <info> | ||
| <title>Société Archéologique de Bordeaux</title> |
There was a problem hiding this comment.
@heleneR24, is this style used beyond the Revue archéologique de Bordeaux?
There was a problem hiding this comment.
The title should also include the language (in English), i.e.: <title>Société Archéologique de Bordeaux (French)</title>
| <term name="editor"> | ||
| <single>(dir.) </single> | ||
| <multiple>(dir.)</multiple> | ||
| </term> |
There was a problem hiding this comment.
@heleneR24, is it correct that <single>(dir.) </single> includes a space and that <multiple>(dir.)</multiple> doesn't?
In general, we also always avoid defining delimiting punctuation (such as parentheses) in term definitions. So here, we would use <single>dir.</single> and <multiple>dir.</multiple>, and add the parentheses where the term is actually used.
There was a problem hiding this comment.
No it's not correct, thank you very much.
I'm not sure I understand your remark. As "dir." or "éd." will always have to be with parentheses, isn't it better to put them in the term name ?
Thank you again !
There was a problem hiding this comment.
Phase 2 : I understood !
|
😃 Your submission passed all our automated tests. |
| <macro name="editor"> | ||
| <names variable="editor"> | ||
| <name and="text" name-as-sort-order="all" sort-separator=", " delimiter-precedes-last="never" delimiter=", "/> | ||
| <label form="short" text-case="lowercase" prefix=", "/> |
There was a problem hiding this comment.
this is fine code-wise, but I want to make sure this is actually what you want: since you removed the parentheses from the term, this will now show up (for example) as "Réveillas, Hélène, dir." -- is that right?
There was a problem hiding this comment.
No you're right. It's not good. I change it thank you.
| <macro name="editor-short"> | ||
| <names variable="editor"> | ||
| <name form="short" delimiter=", " and="text"/> | ||
| <label form="short" text-case="lowercase" prefix=", "/> |
|
The code is all good now -- thanks. I do have one remaining question here: https://github.com/citation-style-language/styles/pull/2298/files#r88812551 |
|
😃 Your submission passed all our automated tests. |
| <term name="editortranslator" form="short"> | ||
| <single>éd.</single> | ||
| <multiple>éd.</multiple> | ||
| <term name="editortranslator"> |
There was a problem hiding this comment.
I want to come back to this one -- looking at your CSL code, this term would never be used. I understand what you want to use it for, but in what situation (speaking from the perspective of a user, be it of Zotero, Mendeley, or another reference manager) would you expect it to appear?
There was a problem hiding this comment.
I would like it to appear when you have for example the edition of a text in latin with the french traduction (and comments in french).
For example : The invectives of Sallust and Cicero : critical edition with introduction, translation, and commentary by Anna A. Novokhatko
|
Hi, |
|
😃 Your submission passed all our automated tests. |
Thanks for the reminder. @adam3smith took some (well-deserved) time off for the holidays, but he can probably wrap this up in the coming week. |
|
Thank you ! :-) |
|
@adam3smith, do you have time to wrap up this one? |
|
What do I have to do ? I thought it was over... |
|
😃 Your submission passed all our automated tests. |
|
Thanks -- I've deleted the editortranslator term, which was not actually used anywhere in the style to avoid confusion. Sorry for the delay in reviewing this. |
|
Ok thank you. So now the style is complete and you will put it on zotero repository ? |
|
It's already on there: https://www.zotero.org/styles?q=id%3Asociete-archeologique-de-bordeaux |
|
Perfect ! Thank you again for everything, especially your patience ! :-) |
Normes pour la revue de la Société archéologique de Bordeaux