-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen the version constraint of prompt_toolkitto avoid dependency #75
Comments
Dependency tree-----
|
Yeah, this is kind of annoying, ipython installation update prompt-toolkit and now it's impossible to use pyinquirer. I should use a virtual environment but this is a very tight constraint and should be relaxed. |
👍 I tried to upgrade it and make a contribution but it's not 100% straightforward and I can't seem to run the tests in the repo. Most fail in the "fake PTY". So I'm not at all at ease to even try and touch it. My solution for the moment has been to "steal" the 2-3 elements (list and confirm) that I needed, upgrade them and use the code directly. |
@gbataille another option would be to use https://github.com/tmbo/questionary - pretty much the same but support for promt toolkit 2 and 3. |
@tmbo thanks! I'll have a look. In the meantime I took the code here, upgrade it (at least to my need) and added a filter search in the list control by typing a prefix on the keyboard. |
This has been fixed now. |
Hi, PyInquirer locked the version constraint of **prompt_toolkitto
** as prompt_toolkitto==1.0.14, which leads to a troubling scenario that its direct downstream project [mqtt-sentinel,infraless, protomate] has to lock prompt_toolkitto.
Could you please loosen the version constraint of prompt_toolkitto?
Benefit of this is that users using both of [mqtt-sentinel,infraless, protomate] and prompt_toolkitto can upgrade their third party libraries in a timely manner to reduce technical debts.
Solution
The dependency trees of your project and affected downstream projects are shown as follows.
Taking the version constraints of upstream and downstream projects into comprehensive consideration, you can
@CITGuru Please let me know your choice. I can submit a PR to fix this issue.
Thanks for your attention.
Best,
Neolith
The text was updated successfully, but these errors were encountered: