Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawning Addon Props - DeSync - on Gamebuild 2944 mp2023_01 San Andreas Mercenaries #2072

Closed
txdaniel55 opened this issue Jun 26, 2023 · 8 comments

Comments

@txdaniel55
Copy link

txdaniel55 commented Jun 26, 2023

We have tried multiple prop spanner scripts and have no issues with stock props, but on this build Addon Props will spawn but only for the player whom spawns them, not the rest of the server. No issues are dumped to either client or server console. This was not an issue on mpchristmas3.

Server: FXServer 6461
Client: Canary

@txdaniel55 txdaniel55 changed the title Spawning Addon Props on Gamebuild 2944#mp2023_01 San Andreas Mercenaries Spawning Addon Props on Gamebuild 2944 mp2023_01 San Andreas Mercenaries Jun 26, 2023
@txdaniel55 txdaniel55 changed the title Spawning Addon Props on Gamebuild 2944 mp2023_01 San Andreas Mercenaries Spawning Addon Props - DeSync - on Gamebuild 2944 mp2023_01 San Andreas Mercenaries Jun 26, 2023
@Disquse
Copy link
Contributor

Disquse commented Jun 27, 2023

What do you mean by "props"? Can you provide any reproduction steps?

@gottfriedleibniz
Copy link
Contributor

There are also a few bits of cleanup required in the AttachDataNode parsing bits. There is no need to git-blame this (:

  1. CPedAttachDataNode and CPhysicalAttachDataNode offsets need a build check: 1604/2060: 45.0/40.0, 2189: 75.0/75.0, and >=2372: 80.0/80.0.
  2. The CPhysicalAttachDataNode quaternion divisor should be 1.0

@txdaniel55
Copy link
Author

txdaniel55 commented Jun 28, 2023

What do you mean by "props"? Can you provide any reproduction steps?

For example using PlaceObjectOnGroundProperly(x)

prop_compressor_01 (from GTA V basegame) will spawn in properly and show for other players, but an addon prop such as: prop_barrier_sign_30 (https://www.gta5-mods.com/misc/signs-barricades-pack), will work properly for the player whom spawned the prop but will not show for any other players and vice versa.

We have tested this using SEM_InteractionMenu and BigDaddy-ObjectSpawner. Both of these scripts produced the same result. When changing ONLY the gamebuild back to mpchristmas3, both scrips and props function properly with the Server Version and Canary Client, but gamebuild mp20223_01 with all the same variables produces this error.

@ebiggz
Copy link

ebiggz commented Jul 17, 2023

It appears clients will only see objects created by other clients when that object model has been created twice. Subsequent spawns of that object model work fine. It's most apparent in emote resources that attach prop objects to player peds, the emote has to be triggered a second time for other clients to see the prop.

This is the only issue holding me back from being able to update to 2944. I would take a stab at resolving this if I was more familiar with the codebase and confident in the language. Hoping someone much more qualified has the opportunity to work their magic! 🙏🏻

@gottfriedleibniz
Copy link
Contributor

createdByOffset changed to 348 in 2944.

@Disquse
Copy link
Contributor

Disquse commented Jul 28, 2023

@gottfriedleibniz I can confirm this issue is caused by wrong createdByOffset, thank you, going to be fixed soon.

@Disquse
Copy link
Contributor

Disquse commented Jul 28, 2023

Going to fix the other stuff you're mentioned soon alongside with some other server state related stuff.

@Forest2357
Copy link

I am not sure if that had been reported. I cannot attach any entity to entity.

Snímek obrazovky 2023-08-13 220835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants