Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPCs Wont stop following #3106

Closed
zacistoasty opened this issue Mar 20, 2024 · 12 comments
Closed

NPCs Wont stop following #3106

zacistoasty opened this issue Mar 20, 2024 · 12 comments

Comments

@zacistoasty
Copy link

/version output

1.20.2

/version Citizens output

2.0.33-b3276

Log file

https://paste.denizenscript.com/View/121178

config.yml

https://paste.denizenscript.com/View/121179

saves.yml

https://paste.denizenscript.com/View/121180

Profiler report

No response

Description

npcs start following me every time the server resets. They also tp to me whenever i go to the end

@Tsoccerguy3
Copy link

Tsoccerguy3 commented Mar 30, 2024

I tested this behavior and confirmed the npc's always continue to follow after the server restarts. Toggling follow off is only temporary until next restart. Definitely, /npc ID follow , is broken .

@Tsoccerguy3
Copy link

confirmed this bug still exists in 1.20.4 Paper

@fullwall
Copy link
Member

Try new build (needs testing before I push to spigot)

@Tsoccerguy3
Copy link

I'm testing the latest build to see if follow is fixed, I will let you know. I did see something in the log about traits, did you update the config file?

[04:11:23] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 4.
[04:11:23] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 5.
[04:11:23] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 7.
[04:11:23] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 11.
[04:11:24] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 10.
[04:11:24] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 12.
[04:11:24] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 13.
[04:11:24] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 15.
[04:11:24] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 17.
[04:11:24] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 19.
[04:11:24] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 24.
[04:11:24] [Server thread/ERROR]: [Citizens] The trait speech failed to load for NPC ID: 26.
[04:11:24] [Server thread/INFO]: [Citizens] Loaded 22 NPCs.

@fullwall
Copy link
Member

fullwall commented Apr 2, 2024

That's an old trait I believe. Should be deleted from saves.yml

@Tsoccerguy3
Copy link

saves.zip

The issue with follow is fixed, I have no idea of why the error with trait speech . Here is my save .yml zipped , no reference to this trait. can you take a look ?

@fullwall
Copy link
Member

fullwall commented Apr 4, 2024

No, I'm not downloading a zip file. In your pasted saves.yml this line only appears once.

@Tsoccerguy3
Copy link

I understand, I will post to pastebin , https://pastebin.com/eZxqy8Vn , I dont know what setting is the old one for the npcs listed above causing the error . could you tell what setting it is?

@Tsoccerguy3
Copy link

I tried deleting speech bubbles , but that had no effect . These trait speech errors appeared after updating to the current commit . Have no idea how it causes this error

@fullwall
Copy link
Member

fullwall commented Apr 6, 2024

delete this line speech: chat which is from old citizens

@zacistoasty
Copy link
Author

wait so the issue is still present in the new build? what should i do

@ListerWorks
Copy link

That worked, thank you! Shut my server down, removed all lines with "speech: chat" from the saves.yml and started back up. No more errors, and the commands I have for my npcs to speak to players still work.

I'm using Citizens 2.0.33-SNAPSHOT (build 3372)
For reference, this is an example of how I normally set up the npcs to speak.

/npc command add "npc speak Whatever text you want your npc to say to a player that right clicks on it. --target

--id "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants