exceptions.AttributeError in rdpy-rdpmitm.py

[adepasquale]

Tested freerdp version 1.2.0_beta1_pre20141115 against rdpmitm, here's the output:

% ./rdpy-rdpmitm.py -o /tmp 192.168.56.3
Unhandled Error
Traceback (most recent call last):
  File "venv/lib/python2.7/site-packages/Twisted-15.0.0-py2.7-linux-x86_64.egg/twisted/python/log.py", line 88, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "venv/lib/python2.7/site-packages/Twisted-15.0.0-py2.7-linux-x86_64.egg/twisted/python/log.py", line 73, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "venv/lib/python2.7/site-packages/Twisted-15.0.0-py2.7-linux-x86_64.egg/twisted/python/context.py", line 118, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "venv/lib/python2.7/site-packages/Twisted-15.0.0-py2.7-linux-x86_64.egg/twisted/python/context.py", line 81, in callWithContext
    return func(*args,**kw)
--- <exception caught here> ---
  File "venv/lib/python2.7/site-packages/Twisted-15.0.0-py2.7-linux-x86_64.egg/twisted/internet/posixbase.py", line 614, in _doReadOrWrite
    why = selectable.doRead()
  File "venv/lib/python2.7/site-packages/Twisted-15.0.0-py2.7-linux-x86_64.egg/twisted/internet/tcp.py", line 215, in doRead
    return self._dataReceived(data)
  File "venv/lib/python2.7/site-packages/Twisted-15.0.0-py2.7-linux-x86_64.egg/twisted/internet/tcp.py", line 221, in _dataReceived
    rval = self.protocol.dataReceived(data)
  File "build/bdist.linux-x86_64/egg/rdpy/core/layer.py", line 209, in dataReceived

  File "build/bdist.linux-x86_64/egg/rdpy/protocol/rdp/tpkt.py", line 195, in readData

  File "build/bdist.linux-x86_64/egg/rdpy/protocol/rdp/x224.py", line 147, in recvData

  File "build/bdist.linux-x86_64/egg/rdpy/protocol/rdp/mcs.py", line 520, in recvConnectInitial

exceptions.AttributeError: 'NoneType' object has no attribute 'channelDefArray'

[adepasquale]

I haven't tried latest master commits on https://github.com/FreeRDP/FreeRDP, should I?

[citronneur]

Very strange bug... Please can you give me the link to 1.2.0_beta1_pre20141115?

[citronneur]

Can you try last commit on hotfix branch?

[adepasquale]

Sure, here it is:

https://github.com/FreeRDP/FreeRDP/archive/7a6c6b7436c2fcb02a38bf89e0b3efcdb43f2ef5.tar.gz
FreeRDP/FreeRDP@7a6c6b7

[adepasquale]

I have pulled your latest commit e9db7d7, now only freerdp prints an error message (rdpmitm prints nothing):

% xfreerdp /v:127.0.0.1 /u:username /p:password       
[15:28:20:146] [25336:-1147242752] [ERROR][com.freerdp.core] - gcc_read_conference_create_response failed
[15:28:20:146] [25336:-1147242752] [ERROR][com.freerdp.core.connection] - rdp_client_connect_mcs_connect_response: mcs_recv_connect_response failed
[15:28:20:146] [25336:-1147242752] [ERROR][com.freerdp.core] - freerdp_set_last_error 0x2000D

But if I connect straight to the RDP server, it works:

% xfreerdp /v:192.168.56.3 /u:username /p:password
[15:30:23:380] [27094:1944729344] [INFO][com.freerdp.client.x11] - Closed from X11

[citronneur]

i try with 1.0.1 version (default on ubuntu) and works fine...

[citronneur]

work with 1.0.2 verion too.

[citronneur]

Ok i fix issue for freerdp last version on last commit on hotfix branch. But works only when mitm use ssl as security layer. I open a new issue for this bug.

[adepasquale]

Thanks, I confirm that now FreeRDP works but rdpy-mitm does not save session.