Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate method badly named and not present in protocol #89

Closed
npahucki opened this issue Jan 8, 2015 · 2 comments
Closed

Delegate method badly named and not present in protocol #89

npahucki opened this issue Jan 8, 2015 · 2 comments

Comments

@npahucki
Copy link
Contributor

npahucki commented Jan 8, 2015

The method -(void) contactcollectionView:(MBContactCollectionView *)contactCollectionView didEnterCustomContact:(NSString*)text can be called on the MBContactPickerDelegate. However, this method suffers from two problems:

  1. It's not named consistently with the other methods, it should be: -(void) contactCollectionView:(MBContactCollectionView *)contactCollectionView didEnterCustomContact:(NSString*)text
  2. This method is NOT declared in the MBContactPickerDelegate protocol, but there is a completely unused method called - (void)contactPicker:(MBContactPicker*)contactPicker didEnterCustomText:(NSString*)text;. I Imagine this this method was meant to have the same function as the misnamed method, but some how got overlooked.

Both super easy fixes. If I get a few moments later today I'll send a pull request.

@MattCBowman
Copy link
Member

Hey @npahucki - I think you found the result of a bad merge 😳. I'll get your updates integrated once you submit. Thanks!

@npahucki
Copy link
Contributor Author

I addressed this in pull request #90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants