Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try-with-resource to close BufferedReaders #1020

Merged
merged 2 commits into from Oct 17, 2023
Merged

Use try-with-resource to close BufferedReaders #1020

merged 2 commits into from Oct 17, 2023

Conversation

picimako
Copy link
Contributor

As discussed on #1001, I changed BufferedReader initializations to use try-with-resource.

bbortt
bbortt requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@bbortt bbortt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think these semicolons are unnecessary, if I may be so picky 😉

...rus-base/src/main/java/org/citrusframework/validation/script/TemplateBasedScriptBuilder.java Outdated Show resolved Hide resolved
core/citrus-base/src/main/java/org/citrusframework/actions/InputAction.java Outdated Show resolved Hide resolved
@bbortt
Copy link
Collaborator

bbortt commented Oct 17, 2023

thanks so much!

@bbortt bbortt merged commit 85fdbb3 into citrusframework:main Oct 17, 2023
1 check passed
@picimako picimako deleted the close-buffered-reader branch November 7, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbortt bbortt bbortt requested changes

Assignees

@picimako picimako

Labels
Prio: Medium State: WIP Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@picimako @bbortt