Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclose GH action secrets within proper quoting rules #740

Open
hanefi opened this issue Aug 26, 2021 · 1 comment
Open

Enclose GH action secrets within proper quoting rules #740

hanefi opened this issue Aug 26, 2021 · 1 comment

Comments

@hanefi
Copy link
Member

hanefi commented Aug 26, 2021

Github recommends that we enclose all our secrets that are passed within a commend line.

Here is the excerpt from GH docs:


If you must pass secrets within a command line, then enclose them within the proper quoting rules. Secrets often contain special characters that may unintentionally affect your shell. To escape these special characters, use quoting with your environment variables. For example:

Example using Bash

steps:
  - shell: bash
    env:
      SUPER_SECRET: ${{ secrets.SuperSecret }}
    run: |
      example-command "$SUPER_SECRET"
@hanefi
Copy link
Member Author

hanefi commented Aug 26, 2021

Before starting to work on this issue, create checklist with all repos and all branches that needs to be checked, and updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant