Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/run make installcheck in docker and travis #553

Merged
merged 4 commits into from
Dec 18, 2020
Merged

Test/run make installcheck in docker and travis #553

merged 4 commits into from
Dec 18, 2020

Conversation

DimCitus
Copy link
Collaborator

@DimCitus DimCitus commented Dec 14, 2020 •
edited

At the moment the make -C src/monitor intallcheck target fails. We often forget to update our test suite for the monitor. This PR includes this step in the travis tests.

Fixes #464

@DimCitus DimCitus added enhancement New feature or request Size: S Effort Estimate: Small Developer productivity Enhancements to ability to ship quality code labels Dec 14, 2020
@DimCitus DimCitus added this to the Sprint 2020 W50 W51 milestone Dec 14, 2020
@DimCitus DimCitus requested a review from JelteF December 14, 2020 16:51
@DimCitus DimCitus self-assigned this Dec 14, 2020
JelteF
JelteF approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out after rebasing on top of #556. The test failed when I edited the .out file. So it works and code LGTM.

@DimCitus DimCitus force-pushed the test/run-make-installcheck-in-docker-and-travis branch from 859cdec to 9604ee0 Compare December 18, 2020 16:51
@DimCitus DimCitus merged commit 6c28439 into master Dec 18, 2020
@DimCitus DimCitus deleted the test/run-make-installcheck-in-docker-and-travis branch December 18, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelteF JelteF JelteF approved these changes

Assignees

@DimCitus DimCitus

Labels
Developer productivity Enhancements to ability to ship quality code enhancement New feature or request Size: S Effort Estimate: Small
Projects
None yet
Milestone
Sprint 2020 W50 W51
Development

Successfully merging this pull request may close these issues.

Running postgres regression tests
2 participants
@DimCitus @JelteF