Feature/docker run make cluster #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimCitus
added
user experience
Size: S
Use tmux set-environment in the top-level tmux script, and then eval $(tmux show-environment -s) in each window that we create with split-window.
Update to current debian testing package list, which now uses Postgres 13 instead of the previous Postgres 12. Make it possible to run the following scenario: $ docker build -t pg_auto_failover . $ docker run --name pg_auto_failover -ti --rm pg_auto_failover pg_autoctl do tmux session
In debian testing the Python pyroute2 librairy has changed in ways that are not compatible with our test suite module for network abstractions: https://docs.pyroute2.org/ipdb_toc.html Warning The IPDB module is deprecated and obsoleted by NDB. Please consider using NDB instead. At the moment, though, documentation is sparse and I failed to find any guide to help with the code migration from IPDB to NDB.
The run container is expected to be public and shared with developpers who want to try pg_auto_failover without having to install anything. We copy files from the build-test environment where we build the full image we need to run our unit test suite.
Trouble is, when using libpq-dev, we then have /usr/bin/pg_config that matches the installed Postgres version (in our controled case, might not be true in general), though we don't have /usr/lib/postgresql/bin/11/pg_config where we would expect it from /usr/lib/postgresql/bin/11/pg_ctl. So we introduce some code that goes from the path to pg_ctl and figures out where the pg_config might well be. When postgresql-server-dev-11 is installed, this is not needed. Most production environment will only install libpq-dev though, and that's what we do also in our Dockerfile, so that we skip the whole build chain.
DimCitus
force-pushed
the
feature/docker-run-make-cluster
branch
from
380f46b
to
85f58c2
Compare
The newer Docker version seems to require that setting to work with our requirements. See #491.
JelteF
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to run the following scenario:
We split the Dockerfile in two separate builds, one that is used to run our test suite, and the other where we only prepare an interactive test environment, and that we should be able to share on dockerhub or other places.
Ideally we will then push our docker image to dockerhub or someplace, and users who just want to see how pg_auto_failover works easily will be able to:
In passing, update to newer Docker requirements with respect to privileges, fixing #491.