Refrain from preventing changes that are not really changes. #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
approved these changes
Jan 15, 2021
When a user runs the same command twice in a row, such as with the
following, make it so that the second time just works. It didn't because we
failed to observe that setting the candidate priority to zero could be a
non-changer if that's already the current value of the setting.
pg_autoctl set node candidate-priority --name node3 0
We could also skip the operation entirely, but this has two drawbacks:
- the client implementation would then need to decide if it has to wait
for the apply-settings steps to happen or immediately return,
- more importantly, if there's a problem with synchronous_standby_names it
might be good that setting a value to its current setting, thus applying
no changes, forces a cache invalidation of the primary's setup.
DimCitus
force-pushed
the
fix/set-node-candidate-priority-idempotency
branch
from
16ad871
to
2f53389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user runs the same command twice in a row, such as with the
following, make it so that the second time just works. It didn't because we
failed to observe that setting the candidate priority to zero could be a
non-changer if that's already the current value of the setting.
pg_autoctl set node candidate-priority --name node3 0
We could also skip the operation entirely, but this has two drawbacks:
the client implementation would then need to decide if it has to wait
for the apply-settings steps to happen or immediately return,
more importantly, if there's a problem with synchronous_standby_names it
might be good that setting a value to its current setting, thus applying
no changes, forces a cache invalidation of the primary's setup.
Fixes #526