Fix a pipe issue and return code #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Between closing the pipe files and waiting the program to exit, the program may write to the closed pipe files, which causes the program got the signal SIGPIPE and exit abnormally. A safer way is to close these pipe files after the program does exit. Another issue is to extract the return code. `WEXITSTATUS(status)` should be only employed if WIFEXITED returned true. Similarly, if `WIFSIGNALED(status)` is true, set the signo as the return code.
DimCitus
requested changes
Mar 15, 2021
|
@DimCitus I've updated the code according to your suggestion. Could you take some time to review it? |
DimCitus
approved these changes
Apr 19, 2021
|
Hi @gfphoenix78 ; I'm just back from some days off and merged your PR. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between closing the pipe files and waiting the program to exit,
the program may write to the closed pipe files, which causes
the program got the signal SIGPIPE and exit abnormally.
A safer way is to close these pipe files after the program does
exit.
Another issue is to extract the return code.
WEXITSTATUS(status)should be only employed if WIFEXITED returned true. Similarly,
if
WIFSIGNALED(status)is true, set the 128+signo as the return code.