Avoid re-electing primary during a switchover. #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a test |
JelteF
reviewed
Jul 13, 2021
When all the nodes are up and running, including the primary, a switchover has a great chance of finding that the current primary is then the best candidate to with the primary election, making the operation a no-op. In this PR we tweak the current primary node's candidate priority in a way that should make it lose the election, and reset the priority when the election is over.
Having two nodes with the same candidate priority, including the primary, makes sure that we promote the node that is not a primary at failover() call time.
DimCitus
force-pushed
the
fix/avoid-re-electing-primary
branch
from
55f4dab
to
f1c4f5a
Compare
I tweaked an existing test to have the current primary and the target primary set to the same candidate priority, making sure that we still promote the target node rather than re-elect the current primary. |
JelteF
approved these changes
Jul 16, 2021
When we fail to run a query on the monitor, it might be because we introduced a SEGFAULT in the pgautofailover extension, and then we need to see Postgres logs to debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all the nodes are up and running, including the primary, a switchover
has a great chance of finding that the current primary is then the best
candidate to with the primary election, making the operation a no-op.
In this PR we tweak the current primary node's candidate priority in a way
that should make it lose the election, and reset the priority when the
election is over.
Fixes #770.