Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deletion of metadata when still in use #49

Closed
jasonmp85 opened this issue Dec 27, 2014 · 1 comment · Fixed by #76
Closed

Prevent deletion of metadata when still in use #49

jasonmp85 opened this issue Dec 27, 2014 · 1 comment · Fixed by #76
Assignees
Milestone

Comments

@jasonmp85
Copy link
Collaborator

Running DROP EXTENSION will remove pg_shard's metadata tables, including information about the placement and health of shards. This behavior should only be possible with the CASCADE modifier: otherwise the extension should refuse to be dropped until all distributed tables have been removed.

Perhaps we can look into the dependency tracking available in PostgreSQL's catalog tables to satisfy this need.

@jasonmp85
Copy link
Collaborator Author

@onderkalaci, in case you pick this up, you might want to look at recordDependencyOnSingleRelExpr and recordDependencyOn, which are helpers for making changes to the pg_depend catalog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants