Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted color for map drawings is red for all types #43

Closed
hiesterd opened this issue Jul 7, 2015 · 4 comments
Closed

Highlighted color for map drawings is red for all types #43

hiesterd opened this issue Jul 7, 2015 · 4 comments
Assignees

Comments

@hiesterd
Copy link
Contributor

hiesterd commented Jul 7, 2015

When hovering over a lane closing, the drawing of the closing on the map turns red, instead of opaque.

@hiesterd
Copy link
Contributor Author

hiesterd commented Jul 7, 2015

This may simply be a configuration oversight. I'll take a look into it and report what I find.

@hiesterd hiesterd self-assigned this Jul 7, 2015
@hiesterd
Copy link
Contributor Author

hiesterd commented Jul 7, 2015

Looks like it's not a configuration issue. @inghamn, can you look into this, and let me know what you find?

The desired highlight style for map lines is for their width to be increased by two pixels, and for the Alpha value of the corresponding RGBA color to go up to 1, and then back down to .6.

@hiesterd hiesterd assigned inghamn and unassigned hiesterd Jul 7, 2015
@inghamn
Copy link
Member

inghamn commented Jul 7, 2015

We swap the entire style out on hover, and color is part of the style. So, there's only a single hover style, and thus, only a single color used when hovering.

I'm not sure if we can dynamically alter the style of a feature. So, far, I've only been able to swap the entire style on a feature.

@hiesterd
Copy link
Contributor Author

hiesterd commented Jul 7, 2015

What if we define entire styles for these different states in the config? E.g.

    [
        'code'        => 'laneRestriction',
        'name'        => 'Lane Restriction',
        'description' => 'expect short delays, signage in place.',
        'default'     => true,
        'rgba'        => [235, 150, 2, .6],
        'rgbaSolid'        => [235, 150, 2, 1],
    ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants