perf(walk): move some processing inside proceed check

haltcase · Jul 21, 2018 · cfabbea · cfabbea
1 parent 76e1582
commit cfabbea
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/glob.nim b/src/glob.nim
@@ -423,16 +423,16 @@ iterator walkGlobKinds* (
       of pcLinkToFile:
         if FileLinks in options: push(path, kind, internalRoot)
 
-  var dir: string
-  when pattern is Glob:
-    dir = maybeJoin(internalRoot, pattern.base)
-    matchPattern = pattern.magic.expandGlob(IgnoreCase in options)
-  else:
-    let stems = splitPattern(matchPattern)
-    dir = maybeJoin(internalRoot, stems.base)
-    matchPattern = stems.magic
-
   if proceed:
+    var dir: string
+    when pattern is Glob:
+      dir = maybeJoin(internalRoot, pattern.base)
+      matchPattern = pattern.magic.expandGlob(IgnoreCase in options)
+    else:
+      let stems = splitPattern(matchPattern)
+      dir = maybeJoin(internalRoot, stems.base)
+      matchPattern = stems.magic
+
     let matcher = matchPattern.globToRegex(ignoreCase = IgnoreCase in options)
     let isRec = "**" in matchPattern