Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble test (+basic usage) causes: Error: 'expandGlob' can have side effects (due to recent change proc => func I guess) #21

Closed
timotheecour opened this issue Jul 21, 2018 · 1 comment
Labels
type: bug Something isn't working as intended or expected.

Comments

@timotheecour
Copy link
Collaborator

git rev-parse HEAD
74031bc

nimble test
  Executing task test in /Users/timothee/git_clone/nim/glob/glob.nimble
  Verifying dependencies for glob@0.7.0
      Info: Dependency on regex@>= 0.6.3 already satisfied
  Verifying dependencies for regex@0.7.1
      Info: Dependency on unicodedb@>= 0.5.1 already satisfied
  Verifying dependencies for unicodedb@0.5.1
      Info: Dependency on unicodeplus@>= 0.3.0 already satisfied
  Verifying dependencies for unicodeplus@0.3.2
      Info: Dependency on unicodedb@>= 0.4 already satisfied
  Verifying dependencies for unicodedb@0.5.1
  Compiling tests.nim (from package glob) using c backend
/Users/timothee/git_clone/nim/glob/tests.nim(1, 8) Warning: Use the new 'sugar' module instead; future is deprecated [Deprecated]
  import future
         ^
/Users/timothee/git_clone/nim/glob/src/glob.nim(142, 8) Warning: Use the new 'sugar' module instead; future is deprecated [Deprecated]
  import future
         ^
/Users/timothee/git_clone/nim/glob/src/glob.nim(301, 6) Error: 'expandGlob' can have side effects
  func expandGlob (pattern: string, ignoreCase: bool): string =
       ^
       Tip: 17 messages have been suppressed, use --verbose to show them.
     Error: Execution failed with exit code 256
        ... Command: "/Users/timothee/.nimble/bin/nim" c --noNimblePath --path:"/Users/timothee/.nimble/pkgs/regex-0.7.1" --path:"/Users/timothee/.nimble/pkgs/unicodedb-0.5.1" --path:"/Users/timothee/.nimble/pkgs/unicodeplus-0.3.2" --path:"/Users/timothee/.nimble/pkgs/unicodedb-0.5.1" "--hints:off" "--verbosity:0" "-r"  "tests.nim"
stack trace: (most recent call last)
Users/timothee/git_clone/nim/glob/glob.nimble(12) testTask
Users/timothee/git_clone/nim/Nim/lib/system/nimscript.nim(237) exec
/Users/timothee/git_clone/nim/Nim/lib/system/nimscript.nim(237, 7) Error: unhandled exception: FAILED: nimble c -y --hints:off --verbosity:0 -r tests.nim

timotheecour added a commit to timotheecour/glob that referenced this issue Jul 21, 2018
@haltcase haltcase added the type: bug Something isn't working as intended or expected. label Jul 21, 2018
@haltcase
Copy link
Owner

You must be using devel, stable Nim hasn't enforced the noSideEffect pragma on funcs yet. Fixed!

Also I just saw you made a PR, I jumped the gun a bit on that 😄 I'll comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working as intended or expected.
Projects
None yet
Development

No branches or pull requests

2 participants