Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] regarding committing docs and auto-updating documentation website #25

Closed
timotheecour opened this issue Jul 23, 2018 · 8 comments
Closed
Labels
discussion [RFC] Fixes, APIs, or changes need feedback. type: documentation Applies only to project documentation.

Comments

@timotheecour
Copy link
Collaborator

timotheecour commented Jul 23, 2018

I'm currently seeing docs/glob/regexer.html + other files

  • ideally docs there would be updated after each PR merged, automatically

implementation

@haltcase haltcase added discussion [RFC] Fixes, APIs, or changes need feedback. type: documentation Applies only to project documentation. labels Jul 24, 2018
@haltcase
Copy link
Owner

I've never generated artifacts like this using CI but it's a good idea (or hooks, if that's better). Would like to find a good way to do this.

@haltcase
Copy link
Owner

haltcase commented Oct 2, 2018

I started this but we're blocked by nim-lang/Nim#9155.

That issue is fixed in devel.

@timotheecour
Copy link
Collaborator Author

great! will try to follow up on nim-lang/Nim#9155.

@timotheecour
Copy link
Collaborator Author

btw, this would (obviously) be useful for all nimble projects out there so making this work would be awesome

@haltcase haltcase added status: in progress Work has started to close the issue. and removed status: in progress Work has started to close the issue. labels Oct 3, 2018
@haltcase
Copy link
Owner

haltcase commented Oct 3, 2018

@timotheecour done! 🎉

Well, not done, but it works heh. There are definitely improvements to be made. Basically how it works is: untagged git commits do nothing extra on Travis and the tests are run as usual.

A tagged commit however (which should be a new version) will trigger a custom Travis deploy script found in .travis_deploy_docs. It builds the docs and overwrites the master directory on the gh-pages branch, then also creates a new directory named with the tag on the commit.

Now I want to put in an index file that catalogs these versions and I think we'll be in good shape.

@timotheecour
Copy link
Collaborator Author

timotheecour commented Oct 3, 2018

Now I want to put in an index file that catalogs these versions and I think we'll be in good shape.

after that I think it'd be worth adding a link to that technique to nim github repo in best practices (permanent, easy to search) or at least a forum entry so others are encouraged to do the same

EDIT
looks like for nim repo itself there's something along those lines since 15 days ago:

"Deploy devel build of docs to https://nim-lang.github.io/Nim" since nim-lang/Nim@308710c

links

@haltcase
Copy link
Owner

haltcase commented Oct 4, 2018

Aight, now it's pretty great. Check it out: https://citycide.github.io/glob/

@haltcase haltcase closed this as completed Oct 4, 2018
@timotheecour
Copy link
Collaborator Author

perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion [RFC] Fixes, APIs, or changes need feedback. type: documentation Applies only to project documentation.
Projects
None yet
Development

No branches or pull requests

2 participants