Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_transformed not set when creating cm #130

Open
gperonato opened this issue Jan 14, 2022 · 2 comments
Open

is_transformed not set when creating cm #130

gperonato opened this issue Jan 14, 2022 · 2 comments
Labels

Comments

@gperonato
Copy link
Contributor

gperonato commented Jan 14, 2022

In the api_tutorial_create.ipynb to create a cm ,is_transformed is not set.
For this reason, cityjson.save() throws an error.

I am not sure whether this is a bug, or the tutorial should be just updated.

In the same tutorial, I think cm.add_to_j(cityobjects,vertex_lookup) should be cm.add_to_j()

@balazsdukai
Copy link
Member

Indeed, the tutorial should be updated.
There is a more up-to-date tutorial at https://github.com/3DGI/3dbag-workshop-foss4gnl2021 , see it's outline.

Everything related to the API is messy, at best. I would have removed it from cjio already if I was done with the alternative...

@gperonato
Copy link
Contributor Author

Ok, thank you for the info and the link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants