Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make App._download_files() a static method #93

Open
johnclary opened this issue Jul 3, 2021 · 0 comments
Open

Make App._download_files() a static method #93

johnclary opened this issue Jul 3, 2021 · 0 comments

Comments

@johnclary
Copy link
Member

johnclary commented Jul 3, 2021

App._download_files() is in fact a static method. We should decorate it as such and drop self in case someone wants to use it as such. Say, for example, you're doing some crazy file migration and you want to monkey patch knackpy for assistance. Me IRL.

I guess it might be more elegant to move the method into Knackpy.api, since that's where the rest of our low-level API methods exist.

The current workaround is to just construct an app instance and call the method manually, which isn't hard.

def _download_files(self, downloads: list):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant