Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_tests.sh fails on latest release 1.5.4 #272

Closed
amo13 opened this issue Dec 25, 2020 · 2 comments
Closed

run_tests.sh fails on latest release 1.5.4 #272

amo13 opened this issue Dec 25, 2020 · 2 comments
Assignees

Comments

@amo13
Copy link
Contributor

amo13 commented Dec 25, 2020

With the latest release 1.5.4, the run_tests fails with the following results:

Creating test database for alias 'default'...
System check identified no issues (0 silenced).
..........................................................F.................s.s...........................................................................................................................
======================================================================
FAIL: test_folder_validation_against_xss_titles (papermerge.test.test_document.TestDocument)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/amo/.cache/yay/papermerge/src/papermerge-1.5.4/papermerge/test/test_document.py", line 369, in test_folder_validation_against_xss_titles
    folder_a.full_clean()
AssertionError: ValidationError not raised

----------------------------------------------------------------------
Ran 202 tests in 13.503s

FAILED (failures=1, skipped=2)
Destroying test database for alias 'default'...

Maybe this (test_folder_validation_against_xss_titles) has something to do with #271?

@amo13 amo13 added the bug Something isn't working label Dec 25, 2020
@ciur
Copy link
Owner

ciur commented Dec 26, 2020

@amo13, the failed test is related to #228. I fixed #228 by escaping user input (correct mitigation of XSS) instead of validating user input with custom filters (latter is checked by failing test). Because custom filters validation "feature" was replaced with escape that tests is obsolete and should be removed anyway.

Let me put in other words: failing test was removed immediately AFTER release 1.5.4 was tagged. Correct it would be to remove failing test BEFORE tagging release 1.5.4.
I am not sure how to mitigate this situation.

@ciur ciur added discussion and removed bug Something isn't working labels Dec 26, 2020
@amo13
Copy link
Contributor Author

amo13 commented Dec 26, 2020

Ok, thank you for your reply!
Good that the failing test has already been removed from the test script :)

I am not sure how to mitigate this situation.

Maybe simply by creating a 1.5.5 release?

@amo13 amo13 closed this as completed Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants